fix(mps-sync-plugin): display the versionHash of the writable binding…#2381
Open
abstraktor wants to merge 1 commit intomainfrom
Open
fix(mps-sync-plugin): display the versionHash of the writable binding…#2381abstraktor wants to merge 1 commit intomainfrom
abstraktor wants to merge 1 commit intomainfrom
Conversation
… in status bar - prefer displaying the hash of writable bindings over just any
Contributor
Test Results 243 files 243 suites 48m 8s ⏱️ Results for commit 1cc1a7a. |
Contributor
JVM coverage report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fun getServerConnections(): List<IServerConnection> | ||
| fun getUsedServerConnections(): List<IServerConnection> | ||
| fun getBindings(): List<IBinding> | ||
| fun isReadonly(binding: IBinding): Boolean |
Check warning
Code scanning / detekt
The function isReadonly is missing documentation. Warning
| result = when (val status = binding.getStatus()) { | ||
| IBinding.Status.Disabled -> "Disabled" | ||
| IBinding.Status.Initializing -> "Initializing" | ||
| is IBinding.Status.Synced -> "Synchronized: ${status.versionHash.take(5)}" |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in status bar